-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is a valid brain seed word count always divisible by 3? #46
Comments
Its an intrinsic property of the encoding algorithm.
I'm not sure how @weilu stumbled across it, but it is a good first pass approximation. |
Ref https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#From_mnemonic_to_seed |
I'll add a comment and the multiple of 4 check too. |
|
See #47 |
It'd be nice to derive an exact proof why this is the case ... otherwise I'd be tempted to remove it in favour of the actual constraint enforcement. |
I'm looking at bip-0039 and I'm not sure why you have this check to make sure the brain seed word count is divisible by 3:
https://github.com/bitcoinjs/bip39/blob/v2.3.0/index.js#L34
Maybe I missed something but I don't see this checking either:
https://github.com/bitpay/bitcore-mnemonic/blob/v1.2.5/lib/mnemonic.js#L110
The text was updated successfully, but these errors were encountered: