Limit ENT to 128-256, multiple of 4 (cont.) #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
May 12, 2017
index.js
Outdated
| throw new Error('Invalid mnemonic') | ||
| } | ||
| if (bits.length < 128) throw new Error(INVALID_MNEMONIC) | ||
| if (bits.length > 264) throw new Error(INVALID_MNEMONIC) |
There was a problem hiding this comment.
@rubensayshi I haven't got time to check, but why does a 24-word mnemonic decode to 264 bits of ENT bits?
dcousens
commented
May 12, 2017
index.js
Outdated
| throw new Error('Invalid entropy') | ||
| } | ||
| // multiple of 4 | ||
| if (entropyHex.length % 8 !== 0) throw new Error(INVALID_ENTROPY) |
dcousens
commented
May 12, 2017
| @@ -90,6 +99,7 @@ function entropyToMnemonic (entropy, wordlist) { | |||
|
|
|||
| function generateMnemonic (strength, rng, wordlist) { | |||
| strength = strength || 128 | |||
| if (strength % 32 !== 0) throw new TypeError(INVALID_ENTROPY) | |||
There was a problem hiding this comment.
not really needed here, would be caught by entropyToMnemonic, alas lets save the RNG some time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will release as a patch, simply because the BIP was updated as if it were a patch...