Remove wordlists from index export #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also index.js no longer depends on any wordlist
| @@ -20,16 +20,16 @@ However, there should be other checks in place, such as checking to make sure th | |||
|
|
|||
| ```javascript | |||
| var bip39 = require('bip39') | |||
| var wordlist = require('bip39/wordlists/en') | |||
There was a problem hiding this comment.
Preferred over bip39/en or bip39/english?
|
ACK, LGTM, just 1 nit which I'm not really phased about, but, IMHO might look nicer by default. We could maybe autobind the word list for each word list import?
|
|
How do you autobind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change set, there's no longer any default word list. Wordlist become a required argument for all functions previously uses the english wordlist as the default. The special check on Japanese wordlist is replaced by the optional delimiter argument, which default to a regular space.
Also added type checking on the affected functions, alongside basic JSDoc.
This change set is based on discussion in #24