Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalizable serialization format #513

Closed
dcousens opened this issue Dec 17, 2015 · 11 comments
Closed

Generalizable serialization format #513

dcousens opened this issue Dec 17, 2015 · 11 comments
Labels
breaking change feature how to / question / docs
Milestone
6.0.0

Comments

@dcousens
Copy link
Contributor

dcousens commented Dec 17, 2015 •
edited

Related to #428, would make patching in alternate crypto currencies much simpler.
Could potentially allow for stricter and more deterministic type checking.

I don't want to over-generalize though, and if this was to be done, it'd definitely be implemented/tested through an external module, not in bitcoinjs-lib.

edit: Should also support encoding of valueBuffer natively
@visvirial visvirial mentioned this issue Dec 19, 2015
Closed
@jprichardson
Copy link
Member

I'm definitely in favor of this and more than happy to take the lead on this. This is something that I definitely need.

@jprichardson jprichardson mentioned this issue Jan 27, 2016
Closed
@dcousens dcousens mentioned this issue Dec 17, 2016
Closed
@dcousens dcousens mentioned this issue Feb 21, 2017
Closed
This was referenced Mar 19, 2017
Closed
Closed
This was referenced Apr 18, 2017
Merged
Closed
@dcousens
Copy link
Contributor Author

@jprichardson taking your time on this one? 😆
Going to un-assign for now

@dcousens dcousens mentioned this issue Aug 23, 2017
Closed
@dcousens dcousens added this to the 4.0.0 milestone Sep 26, 2017
@dcousens
Copy link
Contributor Author

Wants varstruct/varstruct#32

@dcousens
Copy link
Contributor Author

dcousens commented Jun 27, 2018 •
edited

Bump to 5.0.0?
I don't see anything easy to do here that hasn't already been done.

@dcousens dcousens modified the milestones: 4.0.0, 5.0. Jul 3, 2018
@dcousens
Copy link
Contributor Author

dcousens commented Jul 3, 2018

Moved to 5.0.0

@junderw
Copy link
Member

junderw commented Jul 25, 2019

Moving to 6.0.0 ...

@junderw junderw modified the milestones: 5.0.0, 6.0.0 Jul 25, 2019
@brandoncurtis
Copy link

The workflow of using bitcoinjs-lib for multiple coins with network parameters provided by something like https://github.com/cryptocoinjs/coininfo is quite a nice one. This improvement would enable that workflow for coins such as Decred, Zcash (#865), and many more.

@jprichardson
Copy link
Member

yes, I'd love this. Exodus would be willing to fund the work here for this effort.

@junderw
Copy link
Member

junderw commented Aug 14, 2019

tbh, I'm sort of at a loss on how to move forward on this.

Would be nice if we could get a laundry list going.

@sonaye sonaye mentioned this issue May 5, 2020
Merged
@maxchernin
Copy link

maxchernin commented Nov 19, 2021 •
edited

Hi everyone, whats the status on this item? what needs to be done to close it?

@junderw
Copy link
Member

junderw commented Nov 19, 2021

I'm closing this.

@junderw junderw closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change feature how to / question / docs
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@jprichardson @dcousens @brandoncurtis @junderw @maxchernin