Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibyte pubKeyHash #865

Closed
iancoleman opened this issue Aug 23, 2017 · 1 comment
Closed

Multibyte pubKeyHash #865

iancoleman opened this issue Aug 23, 2017 · 1 comment

Comments

@iancoleman
Copy link
Contributor

ZEC uses 0x1CB8 for the pubkeyhash

But the type is forced to be Uint8 so throws an error.

Is this something that can be worked around or will it require changes to bitcoinjs-lib?

@dcousens
Copy link
Contributor

dcousens commented Aug 23, 2017

Only changes required would be in fromBase58Check and toBase58Check, but we'd be forcing those functions to be variable length in their encoding.

I think I can safely say this is something a fork would cover, but, the changes are tiny.

If we add support for #513 - then doing this could be as trivial as the pubKeyHash constant being a fixed length Buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants