Adds version support to Message.verifyMessage #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This also resolves #49 I believe. I'll confirm with some more test cases. |
weilu
added a commit
that referenced
this pull request
Mar 28, 2014
Adds version support to Message.verifyMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #98, at this time you cannot verify a message that is not on the main bitcoin network.
This is due to the address that is being derived from the recovered public key is by default an address with the Bitcoin version.
This pull request resolves this issue by making less assumptions about the
addressinput parameter, letting it be aString,Addressor even byte array (that is, consistent with thenew Addressconstructor); and then derives the address from the version of the input address instead of defaulting.