Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bigi with bn.js, fix example links #1112

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Replace bigi with bn.js, fix example links #1112

merged 3 commits into from
Jun 26, 2018

Conversation

wbobeirne
Copy link
Contributor

Closes #1046 by replacing bigi with bn.js. Also fixes the links to examples in the README, since those were mostly off by a few lines.

@wbobeirne
Copy link
Contributor Author

I mistakenly ran npm run test thinking it would run the relevant tests, but I needed to run npm run integration. I'll fix this up now that I know that.

@wbobeirne
Copy link
Contributor Author

The relevant test is fixed. CI is still failing on other integration tests due to Error: certificate has expired issue unrelated to this PR.

@dcousens dcousens added this to the 4.0.0 milestone Jun 26, 2018
@dcousens dcousens mentioned this pull request Jun 26, 2018
Closed
@dcousens
Copy link
Contributor

dcousens commented Jun 26, 2018 •
edited
Loading

@wbobeirne and this is great!

@dcousens dcousens merged commit 68f687c into bitcoinjs:master Jun 26, 2018
@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Change crypto examples to use bnjs, not bigi
2 participants
@wbobeirne @dcousens