Negative R,S value checking #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enforces positive
randsvalues across all the ECDSA functions that interact with a signature.This bug is a regression introduced by bd1a08b, and thanks to cryptbe on HackerNews for pointing this issue out.
The error checking previously had been written with the assumption that
randswere always positive, which is a valid assumption in an internal use case, but may be a problem if anyone is blindly acceptingECSignatures from outside their application.I also added further tests for
recoverPubKeyin terms of the exceptions it throws.