tests: less ambiguous naming, fix exception check #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Dec 10, 2016
| tmp.__toBuffer(undefined, undefined, true) | ||
| }, 'Verify our replacement of __toBuffer can lead to an error if using witness') | ||
| tx.__toBuffer(undefined, undefined, true) | ||
| }, /hashForSignature MUST pass false/) |
There was a problem hiding this comment.
This must be a regex, or it will be (and was) ignored, provided an exception was thrown.
dcousens
commented
Dec 10, 2016
| @@ -213,27 +213,28 @@ describe('Transaction', function () { | |||
| }) | |||
|
|
|||
| describe('hashForSignature', function () { | |||
| it('only uses V0 serialization', function () { | |||
| it('only uses legacy serialization', function () { | |||
There was a problem hiding this comment.
or, it does not use Witness V0 serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #716, this PR just makes the changes I was after.
It also fixes an exception message not being caught.