package: bump bs58check, drop node 0.12 #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Dec 21, 2016
| @@ -68,7 +67,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "async": "^2.0.1", | |||
| "bs58": "^3.0.0", | |||
| "bs58": "^4.0.0", | |||
There was a problem hiding this comment.
all because this guy used Buffer.from lol
fanatid
approved these changes
Dec 21, 2016
|
Why also not use |
|
@fanatid changes take time, time I didn't have when I was bumping this dependency in a project that needed it 👍 If you can change them over, absolutely go for it, otherwise I'll do it asap |
jprichardson
approved these changes
Dec 21, 2016
|
After reaching out, even companies on |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.