scriptHash.check should be agnostic of classification order #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2017
dcousens
commented
Sep 22, 2017
| bscript.multisig.output.check(redeemScriptChunks)) return true | ||
|
|
||
| if (bscript.pubKey.input.check(scriptSigChunks) && | ||
| bscript.pubKey.output.check(redeemScriptChunks)) return true |
There was a problem hiding this comment.
this also stops recursive P2SH (but removing that wasn't necessary for the fix)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #897
Thanks and credit to @arik-so for reporting the bug, and providing a test case!
The issue is that classifications aren't unique and aren't guaranteed to be un-ambiguous.
scriptHash.checkhas assumed that through usingclassify*internally.Instead, lets match 1 for 1, and if there is a double match, then we can say OK, it is probably script hash.