Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm bitcoin.script circular dependencies with templates #907

Merged
merged 1 commit into from Sep 26, 2017
Merged

Conversation

dcousens
Copy link
Contributor

Resolves #905 (hopefully)

@maxcloudwgh please test

@dcousens dcousens added the bug label Sep 26, 2017
@dcousens dcousens self-assigned this Sep 26, 2017
@dcousens dcousens changed the title rm bscript circular dependencies rm bitcoin.script circular dependencies Sep 26, 2017
@dcousens dcousens changed the title rm bitcoin.script circular dependencies rm bitcoin.script circular dependencies with templates Sep 26, 2017
@mc-tracker
Copy link

Ok,updates is take effect, but new error occurs @dcousens

image

@dcousens
Copy link
Contributor Author

@maxcloudwgh can you provide the call stack for that error?

@mc-tracker
Copy link

@dcousens ,sorry, how to do that

@mc-tracker
Copy link

image

@mc-tracker
Copy link

image

@mc-tracker
Copy link

it seems that input is not required properly

@dcousens
Copy link
Contributor Author

dcousens commented Sep 26, 2017

@maxcloudwgh thanks!
I added e995bc6, see how you go now

@mc-tracker
Copy link

@dcousens awesome, everything works well now!Thanks for your help~

@dcousens
Copy link
Contributor Author

Squashed, ready for review @afk11 @junderw then merge + release

Copy link
Contributor

@afk11 afk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bae9139

@dcousens dcousens merged commit 4f041b2 into master Sep 26, 2017
@dcousens dcousens deleted the nocirc branch September 26, 2017 10:02
@dcousens dcousens added this to the 3.2.1 milestone Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants