Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning specification cleanups #262

Merged

Conversation

carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Jul 12, 2023

Missing Transcripts

Re-add #237 and #236, text is missing on master.

Transcript Titles

Adds dates to each meeting so that the index is easier to read. There's probably a smarter way to do it, but this way seemed easier (and it's a problem that's pretty specific to specification transcripts, so probably doesn't warrant a general fix).

Right now it looks like this:
Screenshot 2023-07-12 at 6 02 51 PM

If we like this solution, I'll update all the open PRs as well.

@adamjonas
Copy link
Member

Those two were breaking my scrapers. I still haven't figured out why but I have them parked here.

Adding the titles isn't my favorite as we've made a deliberate effort to move the dates out of the title, but this move is a direct result of our UI failing you so I understand why. We've been circling around UI updates on bitcointranscripts/bitcointranscripts.github.io#49 without much movement.

Contrary to the paragraph I just wrote, if you are going to make this move, this should last one should have the uniform date format so that it sorts properly.
Screenshot 2023-07-21 at 3 38 53 PM

@carlaKC
Copy link
Contributor Author

carlaKC commented Jul 21, 2023

Those two were breaking my scrapers. I still haven't figured out why but I have them parked

Can I remove the files completely then? Having the ability to click into a transcript with no text is pretty confusing.

Adding the titles isn't my favorite as we've made a deliberate effort to move the dates out of the title, but this move is a direct result of our UI failing you so I understand why.

I do think this problem is pretty distinct to spec meetings (what else has the same name in multiple places).

What about using the agenda issue number? That's the only other distinct identifier other than date.
Eg: Lightning specification call - agenda #xyz

this should last one should have the uniform date format so that it sorts properly

my bad, will fix on next push (if we go with dates).

@adamjonas
Copy link
Member

Agenda works. We are due for a UI update that has the proper metadata.

Originally added in bitcointranscripts#236, currently breaking scrapers. Remove empty
transcript in the meantime.
Originally added in bitcointranscripts#237, currently breaking scrapers. Remove empty
transcript in the meantime.
Without identifying values, all spec meetings show up on the site with
the same name.
@carlaKC carlaKC force-pushed the lightning-specification-cleanups branch from 9a590a4 to 0b6d01f Compare July 24, 2023 14:38
@carlaKC
Copy link
Contributor Author

carlaKC commented Jul 24, 2023

Updated to agendas and removed empty transcripts!

@adamjonas adamjonas merged commit 3aa3180 into bitcointranscripts:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants