Prepare for non-Base58 addresses #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c41224dfd51c896341bbf2fa23e160bf5ffe27c3) Cherry-picked again to XT: Note, this is a partial cherry-pick, since we don't support custom change addresses.
This patch removes the need for the intermediary Base58 type
CBitcoinAddress, by providing {Encode,Decode,IsValid}Destination
function that directly operate on the conversion between strings
and CTxDestination.
dagurval
force-pushed
the
19-01-wrapaddr
branch
from
a492b16
to
a2757d7
Compare
Merged
|
The pick of bitcoin/bitcoin#11247 is actually complete, not partial. |
|
It doesn't have the one-liner change in |
|
Ok, I missed that. |
dgenr8
approved these changes
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from:
bitcoin/bitcoin#11247 - Partial cherry-pick to get IsSpendable
bitcoin/bitcoin#11117 - Prepare for non-Base58 addresses
bitcoin/bitcoin#11259 - Remove duplicate destination decoding
This is a prerequisite to supporting cashaddr.