Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log write to file only work for the first time running #341

Closed
kyuhyong opened this issue Jun 29, 2018 · 3 comments
Closed

Log write to file only work for the first time running #341

kyuhyong opened this issue Jun 29, 2018 · 3 comments
Milestone

Comments

@kyuhyong
Copy link
Contributor

To save the log file into .csv file, I go to Log Blocks and press "Write to file"
This function works fine for the first time however it won't log data the next time.
After first logging into file, next file only contain Timestamp data.
So I have to re run the client everytime I want to log into files.
Attached is the log file created by cfclient

Kyu

log.zip

@kyuhyong
Copy link
Contributor Author

kyuhyong commented Jun 29, 2018

I investigated this issue myself and found there is a bug in logdatawriter.py in /src/cfclient/utils
in line 87, where def stop(selft):
it does not exclusively reset self.header_written to False after resetting self.header_values = []
Adding just
self._header_written = False
remedied this issue and successfully can log into files after again.

@kyuhyong
Copy link
Contributor Author

#342

@krichardsson
Copy link
Contributor

I merged the fix, closing

@krichardsson krichardsson added this to the next_release milestone Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants