Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing tuning script of examples #333

Closed
knmcguire opened this issue May 10, 2022 · 2 comments
Closed

removing tuning script of examples #333

knmcguire opened this issue May 10, 2022 · 2 comments
Labels

Comments

@knmcguire
Copy link
Member

knmcguire commented May 10, 2022

I'm getting an error from python from one of the example scripts to retrieve an parameter update. This is on Windows 11 with python 3.10 with the latest version of the cflib

$ python .\examples\tuning\PID_controller_tuner.py
Waiting for estimator to find position...
update info
velCtlPid.z
velCtlPid.zKp
Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1264.0_x64__qbz5n2kfra8p0\lib\tkinter\__init__.py", line 1921, in __call__
    return self.func(*args)
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1264.0_x64__qbz5n2kfra8p0\lib\tkinter\__init__.py", line 3977, in __call__
    self.__callback(self.__value, *args)
  File "C:\Users\kimbe\Development\bitcraze\python\crazyflie-lib-python\examples\tuning\PID_controller_tuner.py", line 315, in change_param_unit_callback
    self.cf.param.request_param_update(
  File "c:\users\kimbe\development\bitcraze\python\crazyflie-lib-python\cflib\crazyflie\param.py", line 293, in request_param_update
    self.param_updater.request_param_update(
  File "c:\users\kimbe\development\bitcraze\python\crazyflie-lib-python\cflib\crazyflie\param.py", line 632, in request_param_update
    pk.data = struct.pack('<H', var_id)
struct.error: required argument is not an integer
@knmcguire knmcguire added the bug label May 10, 2022
@knmcguire knmcguire changed the title python error parameter update tuning script parameter update velocity gains May 10, 2022
@knmcguire
Copy link
Member Author

This is an error only in the tuning script, as it's logic is written in a sense that it is not able to handle an extra letter to the parametername. So this is an error that happens if a script is trying to get an update from a parameter that does not exist.

@knmcguire
Copy link
Member Author

We should remove this script from the lib for the next release

@knmcguire knmcguire modified the milestone: 0.1.21 Feb 15, 2023
@knmcguire knmcguire changed the title tuning script parameter update velocity gains removing tuning script of examples Feb 15, 2023
@knmcguire knmcguire modified the milestones: next release, 0.1.22 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant