Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warm_up/1 #193

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Add warm_up/1 #193

merged 1 commit into from
Dec 22, 2022

Conversation

maltoe
Copy link
Collaborator

@maltoe maltoe commented Dec 9, 2022

No description provided.

lib/chromic_pdf/pdf/chrome_runner.ex Outdated Show resolved Hide resolved
lib/chromic_pdf.ex Outdated Show resolved Hide resolved
Copy link
Member

@andreasknoepfle andreasknoepfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, little comments.

@maltoe maltoe changed the title Add warmup/1 Add warm_up/1 Dec 14, 2022
@maltoe
Copy link
Collaborator Author

maltoe commented Dec 14, 2022

@andreasknoepfle could you give this another 👀 🙏

@maltoe maltoe enabled auto-merge (rebase) December 22, 2022 09:09
@maltoe maltoe merged commit f8d7a39 into main Dec 22, 2022
@maltoe maltoe deleted the warmup-chrome branch December 22, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants