Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Getting started modal appears when connecting account that has already delegated their BIT #32

Closed
afkbyte opened this issue Sep 13, 2021 · 1 comment
Closed

[BUG] Getting started modal appears when connecting account that has already delegated their BIT #32

afkbyte opened this issue Sep 13, 2021 · 1 comment
Assignees
@neerajbhasin
Labels
bug Something isn't working UI

Comments

@afkbyte
Copy link
Contributor

afkbyte commented Sep 13, 2021

Bug Description

When connecting an account that has already delegated their BIT to the site, the Getting Started modal appears for a few seconds before updating to the Voting Wallet/Delegation modal

Steps to Reproduce

  1. Connect to delegation page with an address containing BIT that has already delegated their BIT

Current Behaviour

Getting started modal appears (~2 seconds) then updates to the Voting Wallet modal

Expected Behaviour

Should display Voting Wallet/Delegation modal immediately

Additional Information

This probably has something to do with the ordering of the checks/response time. May be better to have a standin loading animation while waiting to get all information from the chain.
@afkbyte afkbyte added bug Something isn't working UI labels Sep 13, 2021
This was referenced Sep 13, 2021
Open
Merged
afkbyte added a commit that referenced this issue Sep 14, 2021
@afkbyte
Merge pull request #34 from bitdao-io/neeraj/gettingStartedModalFix
ae07409 
[BUG] Getting started modal appears when connecting account that has already delegated their BIT #32
@afkbyte
Copy link
Contributor Author

afkbyte commented Sep 14, 2021

closed by #34

@afkbyte afkbyte closed this as completed Sep 14, 2021
@afkbyte afkbyte reopened this Sep 14, 2021
@afkbyte afkbyte closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neerajbhasin neerajbhasin

Labels
bug Something isn't working UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afkbyte @neerajbhasin