Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rewrite front end #61

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Feat/rewrite front end #61

merged 6 commits into from
Oct 25, 2021

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Oct 19, 2021

Video Preview:
https://share.vidyard.com/watch/HoWNeGwycDAZ2CE3SNdySA?

Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about code style and one commented section, but LGTM.

src/hooks/useAddressEns.ts Show resolved Hide resolved
'connectedButton' : '#EEF6FF',
'unconnectedButton' : '#57A2D1',
},
// textColor:{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: remove the commented out code.

TODOs and commented out code are not the best look in public code 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will do a cleanup

@octavioamu octavioamu merged commit d6fad23 into develop Oct 25, 2021
@octavioamu octavioamu deleted the feat/rewrite branch October 25, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants