Added support for byte-like objects as input value in pybddisasm. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlutas
reviewed
Aug 13, 2020
| return view->buf; | ||
| } | ||
|
|
||
| buffer = (char *)malloc(sizeof(char) * view->len); |
There was a problem hiding this comment.
Is sizeof(char) really necessary?
vlutas
reviewed
Aug 13, 2020
pybddisasm/_pybddisasm/_pybddisasm.c
Outdated
| @@ -967,18 +967,60 @@ static uint8_t _pybddisasm_py_stack_to_disasm(uint8_t stack) | |||
| } | |||
|
|
|||
|
|
|||
| static char * _pybddisasm_get_contiguous_buffer(Py_buffer *view) | |||
There was a problem hiding this comment.
The * should be placed near the function name.
vlutas
reviewed
Aug 13, 2020
pybddisasm/_pybddisasm/_pybddisasm.c
Outdated
| if (PyBuffer_ToContiguous(buffer, view, view->len, 'C') < 0) | ||
| { | ||
| PyErr_SetString(PyExc_ValueError, "PyBuffer_ToContiguous failed!"); | ||
| free (buffer); |
vlutas
requested changes
Aug 13, 2020
vlutas
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.