Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lines mixed up in KISS ESC info block definition #255

Open
mikeller opened this issue Aug 28, 2017 · 2 comments
Open

Lines mixed up in KISS ESC info block definition #255

mikeller opened this issue Aug 28, 2017 · 2 comments

Comments

@mikeller
Copy link

These two lines are mixed up, they should be in reversed order:

BLHeli/BLHeli_32 ARM/Dshotprog spec.txt

Lines 37 to 38 in 8408abd

15: ESC type (0-0x7F for KISS)
16: ESC sub version letter

@sskaug
Copy link
Collaborator

sskaug commented Aug 28, 2017

As far as I can see, they match Felix's description of July 10 here:
betaflight/betaflight#3267 (comment)

But anyway, I will delete the KISS references from the BLHeli_32 spec.

@mikeller
Copy link
Author

Yes. Testing with hardware showed that this description was buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sskaug @mikeller