Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url query encoding bug #63

Merged
merged 2 commits into from
Aug 23, 2015
Merged

url query encoding bug #63

merged 2 commits into from
Aug 23, 2015

Conversation

bermanjosh
Copy link
Contributor

@bitemyapp Sorry, I missed a small bug based on the different way the query parameter renderer worked

@bitemyapp
Copy link
Owner

@bermanjosh thank you for catching this, but could you write a test that exercises the bug you're fixing please? I don't want a regression to occur.

@bermanjosh
Copy link
Contributor Author

@bitemyapp I'm sorry, but I have no idea why CI is failing. The log says it's tripping hspec-1.12.4. I thought that's excluded in the cabal file.

@bitemyapp
Copy link
Owner

@bermanjosh probably TravisCI is fucking us. Now we do the dance of death where I swat the .travis.yml and bounce your build until it works. Sorry mate, I'll ping you if I run into a non-spurious error. :|

@bitemyapp
Copy link
Owner

@bermanjosh I'm just going to merge it and see what happens.

bitemyapp added a commit that referenced this pull request Aug 23, 2015
@bitemyapp bitemyapp merged commit 2034616 into bitemyapp:master Aug 23, 2015
@bermanjosh
Copy link
Contributor Author

@bitemyapp Good to know I'm not going crazy - let me know if I missed something (again...).

@bermanjosh bermanjosh deleted the scanType branch August 23, 2015 17:37
@bitemyapp
Copy link
Owner

@bermanjosh https://travis-ci.org/bitemyapp/bloodhound/builds/76873638

Nope, you're in good shape. The builds use Stack instead of cabal-install now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants