Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with persistent 2.9 #115

Closed
snoyberg opened this issue Mar 5, 2019 · 3 comments
Closed

Build failure with persistent 2.9 #115

snoyberg opened this issue Mar 5, 2019 · 3 comments

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Mar 5, 2019

> /tmp/stackage-build13$ stack unpack esqueleto-2.6.1@sha256:660d5fa65148ca59370b7f78b5ec1c61150fa789176873323ca9b7661718ffb7
Unpacked esqueleto-2.6.1 to /tmp/stackage-build13/esqueleto-2.6.1/
> /tmp/stackage-build13/esqueleto-2.6.1$ ghc -clear-package-db -global-package-db -package-db=/var/stackage/work/builds/nightly/pkgdb Setup
[1 of 1] Compiling Main             ( Setup.hs, Setup.o )
Linking Setup ...
> /tmp/stackage-build13/esqueleto-2.6.1$ ./Setup configure --package-db=clear --package-db=global --package-db=/var/stackage/work/builds/nightly/pkgdb --libdir=/var/stackage/work/builds/nightly/lib --bindir=/var/stackage/work/builds/nightly/bin --datadir=/var/stackage/work/builds/nightly/share --libexecdir=/var/stackage/work/builds/nightly/libexec --sysconfdir=/var/stackage/work/builds/nightly/etc --docdir=/var/stackage/work/builds/nightly/doc/esqueleto-2.6.1 --htmldir=/var/stackage/work/builds/nightly/doc/esqueleto-2.6.1 --haddockdir=/var/stackage/work/builds/nightly/doc/esqueleto-2.6.1
Configuring esqueleto-2.6.1...
> /tmp/stackage-build13/esqueleto-2.6.1$ ghc -clear-package-db -global-package-db -package-db=/var/stackage/work/builds/nightly/pkgdb Setup
> /tmp/stackage-build13/esqueleto-2.6.1$ ./Setup build
Preprocessing library for esqueleto-2.6.1..
Building library for esqueleto-2.6.1..
[1 of 8] Compiling Database.Esqueleto.Internal.PersistentImport ( src/Database/Esqueleto/Internal/PersistentImport.hs, dist/build/Database/Esqueleto/Internal/PersistentImport.o )

src/Database/Esqueleto/Internal/PersistentImport.hs:56:3: error:
    Not in scope: ‘executeQQ’
   |
56 |   executeQQ,
   |   ^^^^^^^^^

src/Database/Esqueleto/Internal/PersistentImport.hs:57:3: error:
    Not in scope: ‘sqlQQ’
   |
57 |   sqlQQ,
   |   ^^^^^
snoyberg added a commit to commercialhaskell/stackage that referenced this issue Mar 5, 2019
@bitemyapp
Copy link
Owner

@snoyberg Is this from spinning out https://github.com/yesodweb/persistent/tree/master/persistent-qq ? I only vaguely recall the story here.

@parsonsmatt
Copy link
Collaborator

Yeah, that's it. I'm going to do a Hackage revision establishing an upper bound as a quickfix, and I plan on adding some CI improvements which will catch this in the future.

I think we should not reexport persistent-qq functions, for the same reason it was removed. I believe this is technically a breaking change, which would require a 2.7.0 release.

@snoyberg
Copy link
Contributor Author

snoyberg commented Mar 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants