Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distinctOn #287

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix distinctOn #287

wants to merge 4 commits into from

Conversation

parsonsmatt
Copy link
Collaborator

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@parsonsmatt
Copy link
Collaborator Author

Closes #286

ac251
ac251 reviewed Dec 13, 2021
View reviewed changes
src/Database/Esqueleto/PostgreSQL.hs
Comment on lines +101 to +102
distinctOn :: [SqlExpr DistinctOn] -> SqlQuery ()
distinctOn exprs = Q (W.tell mempty { sdDistinctClause = DistinctOn exprs })
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer signature, especially for the experimental syntax. thanks!

@parsonsmatt parsonsmatt added this to the 3.6 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac251 ac251 ac251 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parsonsmatt @ac251