Support nested records in deriveEsqueletoRecord
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
approved these changes
Jul 15, 2022
src/Database/Esqueleto/Record.hs
Outdated
Comment on lines
457
to
459
| case filteredInstances of | ||
| sqlType : _ -> pure $ Just sqlType | ||
| _ -> pure Nothing |
There was a problem hiding this comment.
Suggested change
| case filteredInstances of | |
| sqlType : _ -> pure $ Just sqlType | |
| _ -> pure Nothing | |
| pure $ listToMaybe filteredInstances |
| -- Filter `instances` to the instances which match `originalType`. | ||
| filteredInstances :: [Type] | ||
| filteredInstances = | ||
| flip mapMaybe instances |
There was a problem hiding this comment.
hm, listToMaybe . mapMaybe f is also find (isJust . f) - may be easier or more concise to write like that?
There was a problem hiding this comment.
I don't think so, because find only returns the element but I also need the mapMaybe part to transform and extract the sql type.
parsonsmatt
approved these changes
Jul 19, 2022
parsonsmatt
approved these changes
Aug 1, 2022
|
released as 3.5.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR: