Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetFirstTable #350

Merged
merged 3 commits into from Feb 23, 2023
Merged

Add GetFirstTable #350

merged 3 commits into from Feb 23, 2023

Conversation

9999years
Copy link
Contributor

@9999years 9999years commented Feb 16, 2023

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@belevy
Copy link
Collaborator

belevy commented Feb 16, 2023

Perhaps we should allow manual aliasing and make something like NamedTable @"p1" Person and then you could use the symbol to differentiate

@9999years
Copy link
Contributor Author

@belevy That sounds very neat — how would users assign labels to each table?

@9999years 9999years marked this pull request as ready for review February 17, 2023 20:04
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's bump version + @since annotations and get this out there

@parsonsmatt parsonsmatt merged commit d1a163b into bitemyapp:master Feb 23, 2023
@9999years 9999years deleted the rebeccat/join-on branch February 23, 2023 22:39
isomorpheme added a commit to isomorpheme/esqueleto that referenced this pull request Mar 3, 2023
parsonsmatt pushed a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants