Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict dodges #365

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Name conflict dodges #365

merged 4 commits into from
Jun 8, 2023

Conversation

parsonsmatt
Copy link
Collaborator

This PR adds isNothing_, groupBy_, and updateE as "non-conflicting" variants of the other esqueleto functions. This helps avoid name conflicts and makes it easier to import esqueleto with other libraries.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

Comment on lines +268 to +269
groupBy_ :: (ToSomeValues a) => a -> SqlQuery ()
groupBy_ = groupBy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the main question is: do we want to deprecate the other function names at some point and only have these _ suffixes?

@parsonsmatt parsonsmatt merged commit 494fe5d into master Jun 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant