Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has() returns true for internal dependencies. #38

Closed
shochdoerfer opened this issue May 25, 2016 · 1 comment
Closed

has() returns true for internal dependencies. #38

shochdoerfer opened this issue May 25, 2016 · 1 comment
Assignees
Milestone

Comments

@shochdoerfer
Copy link
Member

AnnotationBeanFactory::has() returns true for "internal dependencies" (methods in config class marked as protected) since method_exists() simply checks if the method does exists not if the method can actually be called from the current context. This is a problem when AnnotationBeanFactory::get() is called since call_user_func() is not able to call the method as intended.

To fix the problem substitute the method_exists() call with is_callable(). This seems to be a side-effect of #10.

@shochdoerfer shochdoerfer self-assigned this May 26, 2016
@shochdoerfer shochdoerfer added this to the 0.4.0 milestone May 26, 2016
@shochdoerfer
Copy link
Member Author

Fixed with #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant