Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.30.0 fails with errors about unexpected items in parameters #301

Closed
hostep opened this issue Apr 7, 2023 · 4 comments · Fixed by #302
Closed

Version 0.30.0 fails with errors about unexpected items in parameters #301

hostep opened this issue Apr 7, 2023 · 4 comments · Fixed by #302

Comments

@hostep
Copy link
Contributor

hostep commented Apr 7, 2023

Hi there

Our pipelines (that always pull in the latest version of this package) started failing with the release of version 0.30.0:

$ vendor/bin/phpstan analyse
Note: Using configuration file phpstan.neon.
Invalid configuration:
Unexpected item 'parameters › extdn'.
Invalid configuration:
Unexpected item 'parameters › magento › checkResourceModelsUsedDirectly'.

Any idea what these errors are about @shochdoerfer ?

@shochdoerfer
Copy link
Member

Huh, that was fast and unexpected ;(

I added new parameters to the extension to configure new rules. Did not expect to break anything ;( Can you post your phpstan.neon file? In the meanwhile, I'll do some more checks. Sorry.

@shochdoerfer
Copy link
Member

Ah my bad, I see the problem. I wonder why our CI pipeline did not fail. Let me fix this quickly.

@shochdoerfer
Copy link
Member

@hostep should be fixed with 0.30.1 - let me know if there are some more issues

@hostep
Copy link
Contributor Author

hostep commented Apr 7, 2023

Yes confirmed, it's fixed now. Thanks for the quick action! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants