DRAFT - mimic bfx websocket api #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcisiozf
force-pushed
the
ws-integration-tests
branch
from
16e51ca
to
807ffcc
Compare
tarcisiozf
commented
May 13, 2021
| @@ -0,0 +1,20 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
this example will be replaced by an actual integration test.
tarcisiozf
commented
May 13, 2021
| @@ -0,0 +1,54 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
this example will be replaced by an actual integration test.
tarcisiozf
commented
May 13, 2021
| const _omit = require('lodash/omit') | ||
|
|
||
| const MAIN_CHAN_ID = 0 | ||
| const SNAPSHOT_TYPES = ['ps', 'ws', 'os', 'fos', 'fcs', 'fls'] |
There was a problem hiding this comment.
replace with constants with better naming
ghost
mentioned this pull request
Merged
tarcisiozf
force-pushed
the
ws-integration-tests
branch
from
28e8dc7
to
3459a89
Compare
|
I'll reopen it with the final implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to have a realistic bfx ws api mock for integration testing.
Design Spec
Real WS behavior:
With some handy components like the WsMock abstraction, we can create real ws servers and compose its message communication patterns.
Providing us realistic network communication testing, enforce async and connection handling.
Pseudo-random data generation:
This allows generating data to simulate market moves without the necessity to store it.
Also, by reusing the same seed as input, we can replay events to generate the output in a deterministic manner.
Extensible components:
The idea is to expand the BitfinexApiMock using event emitters and adapters easily as we are aiming to have low-coupling
(eg. data generators for channel subscriptions)
How to test
I've used the real example provided in
examples/ao_host.jsto create a base API mock that actually works, so basically you can set the environment variable pointing to the API mock:start the API mock:
start the example:
Possible future improvements