-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle min amt for acc/dis algo orders #155
Handle min amt for acc/dis algo orders #155
Conversation
edccf0d
to
4980688
Compare
15c6362
to
bb78432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bb78432
to
ab76db5
Compare
69c495e
to
ed54cb6
Compare
e119289
to
b53bb26
Compare
…ess than the minimum order size
b53bb26
to
e1e7ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, but where possible could we change math operations with nBN operations please? I know that this degrades performance a bit but from previous experience floating prec was a nightmare
> 0.1 + 0.2
0.30000000000000004
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Since, submitting order with an order size less than the minimum order size allowed returns an error, this PR prevents this error from occurring by redistributing the remaining amount to the sliced order amounts if possible.
Features covered:
confirmOrderSubmit
function added in meta of acc/dist algo for UI to show user a pop-up in case the amount entered by user cannot be totalled to sum of individual sliced order amount.Related PR: #174
Task: https://app.asana.com/0/1125859137800433/1200252416166859