Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip outdated ma values for order price calculation #164

Merged
merged 2 commits into from
Jun 23, 2021
Merged

skip outdated ma values for order price calculation #164

merged 2 commits into from
Jun 23, 2021

Conversation

avsek477
Copy link
Contributor

@avsek477 avsek477 commented Jun 9, 2021

  • Skips the ma calculated values from outdated candles

@avsek477 avsek477 force-pushed the skip-outdated-ma-values-in-acc-dist branch from 3612a20 to 81f8508 Compare June 9, 2021 11:32
tarcisiozf
tarcisiozf approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@tarcisiozf tarcisiozf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that we don't have good test coverage for this so this why there are no test changes.

ghost
ghost approved these changes Jun 11, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tarcisiozf
tarcisiozf approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@tarcisiozf tarcisiozf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

robertkowalski
robertkowalski approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@robertkowalski robertkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertkowalski robertkowalski merged commit 2ba9f18 into bitfinexcom:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertkowalski robertkowalski robertkowalski approved these changes

@tarcisiozf tarcisiozf tarcisiozf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avsek477 @robertkowalski @tarcisiozf