Feature: Order creates OcO 2.0.6 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2020
f3rno
changed the title
lib/ococo/meta/process_params.js
Outdated
| } | ||
|
|
||
| if (!params.submitDelay) { | ||
| params.submitDelay = 5000 |
There was a problem hiding this comment.
Why so high? Ping pongs default is only 2000:
if (!_isFinite(params.cancelDelay)) {
params.cancelDelay = 1000
}
if (!_isFinite(params.submitDelay)) {
params.submitDelay = 2000
}
There was a problem hiding this comment.
Fixed; copy-paste mistake, it was also accessing the wrong key for the parameter. Nice catch 🙇♂️
| const { h = {} } = instance | ||
| const { declareEvent } = h | ||
|
|
||
| declareEvent(instance, host, 'self:submit_initial_order', 'submit_initial_order') |
There was a problem hiding this comment.
Nice, didnt realize you could create custom events
| } | ||
|
|
||
| if (!_isFinite(limitPrice)) return 'Invalid OCO limit price' | ||
| if (!_isFinite(stopPrice)) return 'Invalid OCO stop price' |
There was a problem hiding this comment.
We could also check that OCO amount < original order amount otherwise it might be rejected for insufficient balance
There was a problem hiding this comment.
I wouldn't restrict it; if the order fails due to insufficient balance it automatically cancels, and it should be up to the user.
JacobPlaster
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new order type that submits an OCO order after an initial LIMIT/MARKET order fills.
Pending documentation, feature-complete
New features:
PR status: