Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 Normalize #3

Merged
merged 20 commits into from
Sep 23, 2019
Merged

Conversation

f3rno
Copy link

@f3rno f3rno commented Sep 13, 2019

Normalize

This PR is part of a series covering all bfx-api-* and bfx-hf-* repos to standardize their structure and improve Github productivity.

Merge TODO

  • audit Github issues (create where necessary)
  • self review

Extracted Issues

Normalization TODO

  • manifest: bump version to X
  • manifest: ensure author field set to Bitfinex
  • manifest: audit contributors array
  • manifest: bump deps
  • changelog: create or update
  • ensure example exists
  • readme: audit/update
  • convert code TODOs to issues
  • add travis lint/unit file
  • add Issue/PR template
  • ensure npm test exists and runs
  • standard --fix
  • ensure eslint config exists

Other Changes

  • adds getTimeFrames() to AO adapter
  • adds sendWithAnyConnection() to AO adapter
  • fixes ws2 auth event names (listening on bfx-api-node-core Manager)

@f3rno f3rno changed the title [WIP]: v1.0.0 Normalize v1.0.0 Normalize Sep 18, 2019
Copy link

@JacobPlaster JacobPlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacobPlaster JacobPlaster merged commit 6092d84 into bitfinexcom:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants