dazaar: add support for live streams #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertkowalski
force-pushed
the
streams-support
branch
from
70b8b06
to
a7358c9
Compare
robertkowalski
force-pushed
the
streams-support
branch
from
e0bebe3
to
779f92a
Compare
lib/orders/submit_trade.js
Outdated
|
|
||
| let o | ||
| if (liveStream) { | ||
| await submitOrder(state, orderParams) |
There was a problem hiding this comment.
Shouldnt we use o = await submitOrder(state, orderParams) if its a livestream?
There was a problem hiding this comment.
true, but just if its not a custom function which was always the case for me... hmm... thinking...
robertkowalski
force-pushed
the
streams-support
branch
from
779f92a
to
9760468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
dazaar: add support for live streams
Breaking changes:
We could make the new
backtestingflag mandatory, right now we use a fallback for it. Probably good to remove at a later point.So right now no breaking changes.
New features:
backtestingflag to remove ambiguityFixes:
PR status: