Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default label to fix spinning loop that wastes lots of CPU #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

akrennmair
Copy link

The default label in this method serves no purpose, but causes the loop to needlessly spin, wasting lots of CPU. Removing the default label fixes this behaviour without changing the functionality of the loop itself.

@knarz
Copy link
Contributor

knarz commented Nov 7, 2017

Without the default case in the receiver, the select would block until the done channel is closed and never read any messages.

@jvatianou-connamara
Copy link
Contributor

adding this to review/qa pipeline for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants