Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws2] add 'pong' event handler #397

Merged
merged 1 commit into from Sep 15, 2018
Merged

[ws2] add 'pong' event handler #397

merged 1 commit into from Sep 15, 2018

Conversation

mplanes
Copy link
Contributor

@mplanes mplanes commented Sep 10, 2018

'pong' events are ignored in current ws2 implementation.

Since the API update limiting a connection to 50 channels, one may experience no activity whatsoever for more than 10-15 seconds on a connection with illiquid coins.
Emitting a pong event back to the client allows one to make sure the connection is still up.

@f3rno
Copy link
Contributor

f3rno commented Sep 15, 2018

@mplanes good idea, thanks for the contribution 🙂

@f3rno f3rno merged commit c9ed744 into bitfinexcom:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants