Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this a real library (instead of a submodule) #13

Closed
5 tasks
rfc2822 opened this issue May 15, 2023 · 4 comments
Closed
5 tasks

Make this a real library (instead of a submodule) #13

rfc2822 opened this issue May 15, 2023 · 4 comments
Assignees

Comments

@rfc2822
Copy link
Member

rfc2822 commented May 15, 2023

We would have to care less about compile-time settings when this would be a real library. It would be easier to integrate with other projects.

I think of this is a separate library that

  • can be added as a normal dependency and then be used in other projects

  • has two components, something like a lib and and sample-app directory:

    • lib contains the lib and is what is imported when other projects add the dependency
    • sample-app contains a minimum sample app that also allows to test cert4android in real when debugging (not imported with the dependency)
  • make it a jitpack library

  • document how to embed the library

  • separate demo app from lib

    • build action for jitpack should only build lib
    • demo app can be opened in Android Studio to test and work on the lib
@ArnyminerZ
Copy link
Member

I think the easiest approach would be to use something like JitPack. It's the fastest way to deploy libraries.

However, we can also upload them to MavenCentral, even though it is tougher, I think we would have more control on deployment. I've done this in the past, but I would have to come back and check what I did, since it's been a while.

If this is what we prefer over JitPack, I can take a look.

@rfc2822
Copy link
Member Author

rfc2822 commented May 15, 2023

Yes, jitpack is fine. It's already used for dav4jvm. There may however be a difference between .jar and .aar libraries; cert4android would probably be an .aar.

@ArnyminerZ ArnyminerZ self-assigned this May 16, 2023
@ArnyminerZ
Copy link
Member

According to JitPack's documentation you must first configure the maven-publish plugin (there's a guide in Android Developers), I'll take a look and give further steps

@ArnyminerZ ArnyminerZ added this to the Make it a library milestone May 17, 2023
@ArnyminerZ
Copy link
Member

I've created a PR for this changes on #14, further instructions are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants