Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android always expects RRULE UNTIL to be in UTC format #54

Closed
rfc2822 opened this issue Sep 8, 2022 · 2 comments
Closed

Android always expects RRULE UNTIL to be in UTC format #54

rfc2822 opened this issue Sep 8, 2022 · 2 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@rfc2822
Copy link
Member

rfc2822 commented Sep 8, 2022

Currently, we insert RRULE with UNTIL as it comes from the event (as defined in RFC 5445).

However, some code parts of the Android calendar provider seem to always expect UNTIL to be in UTC format, as specified in the obsolete RFC 2445.

So RRULE UNTIL should always be converted to UTC before inserting it into the calendar provider. Not doing so might result in losing the last occurrence.

Side note: ical4j parses UNTIL in the system default timezone and not in the DTSTART timezone. This may cause further problems…

@rfc2822 rfc2822 added the bug Something isn't working label Sep 8, 2022
@sunkup
Copy link
Member

sunkup commented Dec 13, 2022

I am tad confused by this. Ical4j seems to express UNTIL in UTC time straight away after parsing it. See https://github.com/ical4j/ical4j/blob/develop/src/main/java/net/fortuna/ical4j/model/Recur.java#L283.

What makes you think it goes into the calendar provider in non UTC format - is it reproducible?

@rfc2822 rfc2822 added the invalid This doesn't seem right label Apr 13, 2023
@rfc2822
Copy link
Member Author

rfc2822 commented Apr 13, 2023

I couldn't reproduce it.

@rfc2822 rfc2822 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants