Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better separation of AndroidEvent <-> (iCalendar) Event #56

Closed
rfc2822 opened this issue Sep 11, 2022 · 5 comments
Closed

Better separation of AndroidEvent <-> (iCalendar) Event #56

rfc2822 opened this issue Sep 11, 2022 · 5 comments
Labels
dependent refactoring Quality improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Sep 11, 2022

ical4j comes with a time zone database that is used for its calculations and for instance to generate VTIMEZONEs which are then exported.

However, Java/Android has its own database (which is used by the calendar provider and the ZoneId, java.util.TimeZone classes). We always need to know which times with time zone are in the "ical4j namespace" and which ones are in "Android namespace".

There should be a proper separation and it should be documented and enforced.

ical4j 4.x comes with major changes. This issue should be done when we have ical4j 4.x (if at all). Depends on #106

@rfc2822 rfc2822 added the refactoring Quality improvement of existing functions label Sep 11, 2022
@rfc2822
Copy link
Member Author

rfc2822 commented Sep 26, 2022

Additional note: There are time zone IDs that are known to Android but not to ical4j (should also be handled)

@rfc2822
Copy link
Member Author

rfc2822 commented Sep 26, 2022

Maybe it would be useful to:

  • create annotations for the "timezone name spaces" (@Ical4jTz, @AndroidTz)
  • define which tz registry is used for what (reading from Android provider, parsing iCals etc)

@rfc2822
Copy link
Member Author

rfc2822 commented Nov 3, 2022

Idea: maybe

  • dtStart in Event (has iCalendar timezone) →
  • dtAndroidStart in AndroidEvent (converted from Event.dtStart, has Android timezone)

@rfc2822 rfc2822 changed the title Use Android time zone database as source for ical4j timezones / VTIMEZONEs Better separation of AndroidEvent <-> (iCalendar) Event Nov 3, 2022
@github-actions
Copy link

This PR/issue depends on:

@rfc2822
Copy link
Member Author

rfc2822 commented Sep 24, 2023

Has to be specified in detail when it's time for that.

@rfc2822 rfc2822 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent refactoring Quality improvement of existing functions
Projects
None yet
Development

No branches or pull requests

1 participant