Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright information in About dialog #148

Closed
devvv4ever opened this issue Apr 15, 2023 · 1 comment · Fixed by #222
Closed

Add copyright information in About dialog #148

devvv4ever opened this issue Apr 15, 2023 · 1 comment · Fixed by #222
Assignees
Labels
enhancement New feature or request pending-pr The issue has been solved, and there's a PR open for it.

Comments

@devvv4ever
Copy link
Member

devvv4ever commented Apr 15, 2023

I came across this because HUAWEI complained for "missing" copyright information. Missing in the sense that no entity is responsible for the uploaded app (and visible inside the app) - which is not compliant with their app distribution policy (anymore?). I also had to add our business license for DAVx5 last year and did so for ICSx5 now.

Currently we only have the GPLV3 link in the About dialog (for all stores the same) without any legal entity or names. I think we need to add bitfire as copyright owner for this like we do it with DAVx5. But I also think that we can keep the GPLV3 link. So then it is clearly shown that bitfire licenses the software under GPL and we also don't have to make flavors in Android studio to deal with different information for certain stores.

grafik

grafik

@devvv4ever devvv4ever changed the title Add copyright information in About dialog for stores Add copyright information in About dialog Apr 15, 2023
@ArnyminerZ
Copy link
Member

I think the quickest workaround is to use the withAboutSpecial2 of LibsBuilder. It looks like this:
copy

copy_text

Otherwise we can simply update the "Subscribe to Webcal feeds" text with the copyright notice. However, we should remove the existing translations, or rename the string to Transifex takes care of the update.

@ArnyminerZ ArnyminerZ self-assigned this Feb 28, 2024
@ArnyminerZ ArnyminerZ added enhancement New feature or request pending-pr The issue has been solved, and there's a PR open for it. labels Feb 28, 2024
@ArnyminerZ ArnyminerZ linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending-pr The issue has been solved, and there's a PR open for it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants