Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IM entries: use pre-defined protocols for Android<12 again #3

Closed
rfc2822 opened this issue Mar 4, 2022 · 2 comments · Fixed by #4
Closed

IM entries: use pre-defined protocols for Android<12 again #3

rfc2822 opened this issue Mar 4, 2022 · 2 comments · Fixed by #4
Assignees
@rfc2822

Comments

@rfc2822
Copy link
Member

rfc2822 commented Mar 4, 2022 •
edited

On Android <12, the pre-defined protocols for IM can still be used.

On Android ≥ 12 there are still open questions.

See https://forums.bitfire.at/topic/2690/jabber-im-entry-sync-as-xmpp/.
@rfc2822
Copy link
Member Author

rfc2822 commented Mar 7, 2022 •
edited

ImHandler should work as it is. ImBuilder should be changed:

  • if the protocol is one of ICQ, AIM, Skype, …, use the corresponding PROTOCOL_AIM, … entry instead of PROTOCOL_CUSTOM (although PROTOCOL_AIM is obsolete)
  • use X-ABLABEL (LabeledProperty.label) for the full messenger name (PROTOCOL_CUSTOM) instead of a possible custom type (home, work, … labeled)

@sunkup sunkup linked a pull request Mar 7, 2022 that will close this issue
use pre-defined protocols again #4
Merged
@rfc2822
Copy link
Member Author

rfc2822 commented Mar 9, 2022

Idea: correspondence table: URI scheme ↔ messenger name (for known messengers); fallback to generic conversion

@rfc2822 rfc2822 closed this as completed in #4 Mar 9, 2022
@rfc2822 rfc2822 reopened this Mar 10, 2022
@rfc2822 rfc2822 closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rfc2822 rfc2822

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use pre-defined protocols again bitfireAT/vcard4android
2 participants
@rfc2822 @sunkup