Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.5 seems to trigger a panic in rls rust language server, locking to 1.0.4 resolves it #177

Closed
anticrisis opened this issue May 3, 2019 · 2 comments
Closed

1.0.5 seems to trigger a panic in rls rust language server, locking to 1.0.4 resolves it #177

anticrisis opened this issue May 3, 2019 · 2 comments

Comments

@anticrisis
Copy link

Just thought you should be aware of this: rust-lang/rls#1449

This panic causes editor integration in Visual Studio Code to break, among possibly other effects.

Workaround: Locking to 1.0.4 seems to resolve the problem for several people, myself included.

[dependencies]
bitflags = "=1.0.4"
This was referenced May 6, 2019
Closed
Closed
@vadixidav
Copy link

As was pointed out, 1.0.5 can just be yanked to limit the impact and republished as 1.0.6 after it works with the RLS again.

@KodrAus KodrAus closed this as completed May 7, 2019
@KodrAus
Copy link
Member

KodrAus commented May 7, 2019

We’ve yanked 1.0.5 for now so folks won’t have to pin a particular version of bitflags.

@mystor mystor mentioned this issue May 28, 2019
Closed
@KodrAus KodrAus mentioned this issue Jun 5, 2019
Merged
bors bot added a commit that referenced this issue Jun 6, 2019
@bors @KodrAus
Merge #181
fffdfe8 
181: Prepare for 1.1.0 release r=KodrAus a=KodrAus

Closes #178

Now that #177 has been solved upstream in `1.35.0`, we can republish the `bitflags` that includes support for constant functions.

I opted to make this `1.1.0` rather than `1.0.6` since it's possible folks are still using older compilers that will break, and `1.0.5` probably should've been `1.1.0` anyways, since it was just fixing bugs.

Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KodrAus @vadixidav @anticrisis