Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Self & fix bug when overriding stringify! #249

Merged
merged 2 commits into from Aug 5, 2021

Conversation

konsumlamm
Copy link
Contributor

@konsumlamm konsumlamm commented Aug 4, 2021

Using Self instead of $BitFlags is cleaner imo and makes the code more readable.

There was a bug when overriding stringify!, which I fixed and added a test case for (see tests/redefinition.rs).

konsumlamm added 2 commits Aug 4, 2021
Fix bug when overriding `stringify!`
KodrAus
KodrAus approved these changes Aug 5, 2021
Copy link
Member

@KodrAus KodrAus left a comment

Thanks @konsumlamm! This is a nice improvement

@KodrAus KodrAus merged commit 9defa89 into bitflags:master Aug 5, 2021
5 checks passed
@konsumlamm konsumlamm deleted the self branch Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants