Add support for no_std #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[cfg(all(feature = "no_std", test))] | ||
| #[macro_use] | ||
| extern crate std; |
There was a problem hiding this comment.
You may actually be able to get away with extern crate std as core here and avoid the #[cfg] below
There was a problem hiding this comment.
Something like this?
// Compile the crate with no_std if possible. The "no_std" feature can be
// removed once no_std becomes available in 1.6.0 stable. In the meantime no_std
// must be disabled by default to allow the crate to work on older rust versions.
#![cfg_attr(feature = "no_std", no_std)]
#[cfg(all(feature = "no_std", test))]
#[macro_use]
extern crate std;
#[cfg(not(feature = "no_std"))]
extern crate std as core;
// Re-export libcore using an alias so that the macros can work in no_std crates
// while remaining compatible with normal crates.
#[doc(hidden)]
pub use core as __core;
|
Looks good to me, thanks! |
phil-opp
referenced
this pull request
in sos-os/kernel
Jan 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for no_std by adding a "no_std" cargo feature. The use of the cargo feature is needed for now because stable rust does not support no_std yet. Once 1.6.0 is released then the feature can be removed and bitflags can be made unconditionally no_std.
Fixes #27