Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some new pedantic clippy lints #380

Merged
merged 5 commits into from Oct 15, 2023

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Oct 9, 2023

Closes #379
Closes #378

This PR will use clippy in the compile-pass tests if it's available. This gives us slightly more coverage for clippy on generated code than just on the smoke-test.

@KodrAus KodrAus changed the title Run clippy in compile-pass tests if available Allow some new pedantic clippy lints Oct 9, 2023
@KodrAus
Copy link
Member Author

KodrAus commented Oct 9, 2023

Actually, running clippy if it's available is a bit odd, so I'll back that bit out and just keep the fix for the new pedantic lints and doc comments.

@KodrAus KodrAus merged commit dd91b82 into bitflags:main Oct 15, 2023
9 checks passed
@KodrAus KodrAus deleted the ci/compile-pass-clippy branch October 15, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::iter_without_into_iter Documenting bitflags: how to get documentation for the generated bitflags
1 participant