Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old unused_tuple_struct_fields lint #393

Merged
merged 1 commit into from Jan 16, 2024

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Jan 16, 2024

unused_tuple_struct_fields no longer exists in Rust 1.77 since rust-lang/rust#118297. It has been subsumed by dead_code.

This is causing the "smoke test" in CI to fail.

- name: Smoke test
run: cargo run --manifest-path tests/smoke-test/Cargo.toml

$ cargo run --manifest-path tests/smoke-test/Cargo.toml

error: lint `unused_tuple_struct_fields` has been renamed to `dead_code`
  --> src/main.rs:38:5
   |
38 |     unused_tuple_struct_fields,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `dead_code`
   |
note: the lint level is defined here
  --> src/main.rs:6:5
   |
6  |     warnings,
   |     ^^^^^^^^
   = note: `#[deny(renamed_and_removed_lints)]` implied by `#[deny(warnings)]`

    error: lint `unused_tuple_struct_fields` has been renamed to `dead_code`
      --> src/main.rs:38:5
       |
    38 |     unused_tuple_struct_fields,
       |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `dead_code`
       |
    note: the lint level is defined here
      --> src/main.rs:6:5
       |
    6  |     warnings,
       |     ^^^^^^^^
       = note: `#[deny(renamed_and_removed_lints)]` implied by `#[deny(warnings)]`
@KodrAus
Copy link
Member

KodrAus commented Jan 16, 2024

Thanks @dtolnay!

@KodrAus KodrAus merged commit b988b1a into bitflags:main Jan 16, 2024
9 checks passed
@dtolnay dtolnay deleted the lint branch January 16, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants