Implement Extend for bitflags #49

kamalmarhubi · 2016-04-23T17:19:48Z

This commit adds an Extend impl, and redefines the FromIterator impl
to use it.

alexcrichton · 2016-04-24T05:05:04Z

src/lib.rs

        impl $crate::__core::iter::FromIterator<$BitFlags> for $BitFlags {
+            #[inline]


It should be fine to remove this #[inline] because the function is already generic which will inline it elsewhere anyway

Ah good to know, thanks! (Done.)

alexcrichton · 2016-04-24T05:05:09Z

Neat!

This commit adds an `Extend` impl, and redefines the `FromIterator` impl to use it.

kamalmarhubi force-pushed the impl-extend branch 2 times, most recently from 10422c8 to 96d6457 Compare April 23, 2016 17:26

alexcrichton reviewed Apr 24, 2016
View reviewed changes

Implement Extend for bitflags

2e76c36

This commit adds an `Extend` impl, and redefines the `FromIterator` impl to use it.

kamalmarhubi force-pushed the impl-extend branch from 96d6457 to 2e76c36 Compare April 24, 2016 06:04

alexcrichton merged commit 88addbf into bitflags:master Apr 24, 2016

Provide feedback

		impl $crate::__core::iter::FromIterator<$BitFlags> for $BitFlags {
		#[inline]