Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u128 feature for complete u128 compatibility #57

Merged
merged 6 commits into from
Feb 12, 2017

Conversation

astocko
Copy link
Contributor

@astocko astocko commented Feb 11, 2017

Added a u128 feature with a feature gated bitflags width type for use in the macro. Enables functionality like debug formatting of flags that exceed 64 bits. #56

@alexcrichton
Copy link
Contributor

This seems to only be used in the formatting pieces, and there could we just use $T instead of an explicit size? That way we could defer this decision entirely to downstream crates I think?

@astocko
Copy link
Contributor Author

astocko commented Feb 11, 2017

Implemented as suggested. The change does require absolute paths for custom types and type aliases.

@alexcrichton
Copy link
Contributor

Oh right sorry I forgot about that :(, that's actually a pretty crucial reason for this feature.

In that case I guess we'll have to stick with an unstable feature

@astocko
Copy link
Contributor Author

astocko commented Feb 11, 2017

I will revert to my original PR. Any comments or suggestions?

@alexcrichton
Copy link
Contributor

Looks like this may still be the requires-absolute-paths version?

@alexcrichton alexcrichton merged commit b7178e5 into bitflags:master Feb 12, 2017
@alexcrichton
Copy link
Contributor

Thanks!

@dtolnay
Copy link
Contributor

dtolnay commented Mar 7, 2017

#61 reimplements this in a different way that neither requires absolute paths nor a cfg to opt into u128 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants