Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semicolons instead of commas. #87

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

topecongiro
Copy link
Contributor

Closes #65.

@dtolnay
Copy link
Contributor

dtolnay commented Mar 22, 2017

This is a bit more complicated because commas are treated as separators with an optional trailing separator, while semicolons need to be treated as terminators.

{ a, b, c } // ok
{ a, b, c, } // ok
{ a; b; c; } // ok
{ a; b; c } // not ok

The pairs of rules that look like this:

$($(#[$Flag_attr:meta])* const $Flag:ident = $value:expr);+
$($(#[$Flag_attr:meta])* const $Flag:ident = $value:expr);+;

need to be replaced by a single rule that looks like this:

$($(#[$Flag_attr:meta])* const $Flag:ident = $value:expr ;)+

@topecongiro
Copy link
Contributor Author

@dtolnay Thank you for your comment. I will change my PR accordingly.

@alexcrichton
Copy link
Contributor

Looks great to me, thanks @topecongiro! Want to rebase and I'll merge?

@topecongiro
Copy link
Contributor Author

@alexcrichton Thank you! Rebased.

@alexcrichton alexcrichton merged commit 2b8681a into bitflags:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants